BD-3746 -- refactor auto proxy logic in fio

Owned by Ed Rotthoff
Last updated: Jun 08, 2023
1 min read

 

 

purpose

 

the purpose of this document is to capture working notes regarding the update of auto proxy logic in the FIO Protocol for use when bundled fees are collected. The goal is to review all code locations using bundled fees and verify that auto proxy is being handled correctly, if not then correct the logic for the action.

 

 

tests:

I created a new file to test all auto proxy endpoints in the protocol.

https://github.com/fioprotocol/fio.test/pull/353

 

to get a summary of endpoints using bundled fee

../fio/build/bin/clio -u https://fio.greymass.com get table fio.fee fio.fee fiofees --limit 100 | grep -A1 -B3 '\"type\": 1'

 

 

 

testing and code review findings --

tests have been created for the following endpoints. each is failing to auto proxy as expected.

      "end_point": "add_pub_address"

      "end_point": "new_funds_request"

       "end_point": "reject_funds_request"

"end_point": "cancel_funds_request",

      "end_point": "record_obt_data",

"end_point": "remove_pub_address",

      "end_point": "remove_all_pub_addresses",

       "end_point": "burn_fio_address",

     "end_point": "add_nft",

     "end_point": "remove_nft",

      "end_point": "remove_all_nfts",

 

 

the following items have is_auto_proxy testing in the existing tests, and will not be tested further.

      "end_point": "proxy_vote", this call should clear is_auto proxy. ALREADY TESTED and passing IN tpid.js!! will not test

      "end_point": "vote_producer", this call should clear is_auto_proxy. ALREADY TESTED and passing IN tpid.js will not test

       "end_point": "stake_fio_tokens", ALREADY TESTED and passing in staking-regression.js will not test

      "end_point": "unstake_fio_tokens", ALREADY TESTED and passing in staking-regression.js will not test.